aimclub / GOLEM

Graph Optimiser for Learning and Evolution of Models
https://thegolem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
60 stars 7 forks source link

Set random_seed for stohastic integration tests #217

Closed maypink closed 5 months ago

maypink commented 11 months ago

Seeds for various sources of random are fixed in a fixture to stabilize tests. Also, a test is added that checks that the seeds indeed fully determine the evolution process.

pep8speaks commented 11 months ago

Hello @maypink! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1:1: F401 'logging' imported but unused

Line 1:1: F401 'random' imported but unused

Line 1:1: F401 'unittest.mock.patch' imported but unused Line 5:1: F401 'golem.utilities.utilities.urandom_mock' imported but unused Line 6:1: F401 'test.integration.test_quality_improvement.run_graph_trial' imported but unused

Comment last updated at 2024-04-22 14:03:56 UTC
codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.76%. Comparing base (68706be) to head (e8035ac).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #217 +/- ## ========================================== - Coverage 72.88% 72.76% -0.12% ========================================== Files 140 141 +1 Lines 8338 8347 +9 ========================================== - Hits 6077 6074 -3 - Misses 2261 2273 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nicl-nno commented 7 months ago

А можно это мержить или что-то осталось?

maypink commented 7 months ago

А можно это мержить или что-то осталось?

насколько я помню, тут надо покопаться, что-то не работало. отдам ее @donRumata03