aimclub / GOLEM

Graph Optimiser for Learning and Evolution of Models
https://thegolem.readthedocs.io
BSD 3-Clause "New" or "Revised" License
60 stars 7 forks source link

Crossover for graphs with cycle #231

Closed YamLyubov closed 4 months ago

YamLyubov commented 11 months ago

Adds crossover suitable for graphs with cycles. Uses http://alglobus.net/NASAwork/papers/JavaGenes2/JavaGenesPaper.html

pep8speaks commented 11 months ago

Hello @YamLyubov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-06-04 10:50:40 UTC
aim-pep8-bot commented 11 months ago

Hello @YamLyubov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2023-10-27 13:26:52 UTC
codecov-commenter commented 11 months ago

Codecov Report

Merging #231 (d34619c) into main (fcc23ec) will decrease coverage by 2.32%. Report is 6 commits behind head on main. The diff coverage is 25.80%.

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   73.75%   71.43%   -2.32%     
==========================================
  Files         131      136       +5     
  Lines        7834     8220     +386     
==========================================
+ Hits         5778     5872      +94     
- Misses       2056     2348     +292     
Files Coverage Δ
...lem/core/optimisers/genetic/operators/crossover.py 83.96% <46.66%> (-8.82%) :arrow_down:
golem/core/dag/graph_utils.py 69.62% <6.25%> (-26.78%) :arrow_down:

... and 30 files with indirect coverage changes