search

aimed / foxxy

🦊 Foxxy - a really foxy random movie picker!
https://foxxy.surge.sh
1 stars 0 forks source link

Hi #2

Open dewster opened 6 years ago

dewster commented 6 years ago

is there a way to give "language" to api url? (for example: https://api.themoviedb.org/3/movie/76341?api_key=<>&language=de) and where can I find the color code of the "menu" text in scss?

Ty for answer and sorry my bad eng.. have a nice day ^^

aimed commented 6 years ago

Hey @dewster,

the api wrapper currently doesn't support languages, it should be easy to add to https://github.com/aimed/foxxy/blob/master/src/Api/TMDB/TMDBConnection.ts tho. An appropriate default seems to be the preferred user language accessible using the navigator object. I have some spare time later and can take care of it, otherwise feel free to make a pull request :)

Regarding the colors: after I switched to material components, the colors are defined here https://github.com/aimed/foxxy/blob/1708ab33465795cb60eaadd89d265f0200ae27cf/src/index.scss#L1 The material components button uses the primary color as the text color by default.

And thanks for the interest in the project :) Quick question: are you mostly interested in the API wrapper or the project in general? I'd be happy to extract the API wrapper into an npm project :)

dewster commented 6 years ago

hi thank you for your answer! now i am familiar with the React and Typesript I've been looking for an interesting project ^^ and this awesomen^^!

aimed commented 6 years ago

Always 👍 , if you have any questions or ideas, just ask :)

Had some time and added the locale support very roughly :)

dewster commented 6 years ago

Ty ^^

dewster commented 6 years ago

100% work localization ^^