search

aimementoring / blueprint

This project defines some standards for all AIME platforms.
5 stars 0 forks source link

Styling validation error msg #185

Closed lulen11 closed 4 years ago

lulen11 commented 4 years ago

Hey @davidpaley - It was on the withValidation component. I did some work restyling the error message on the Checkbox component but didn't end up pushing it up. It was because we're not using theming properly on the validation so instead I have put in some fallback styles if we don't use theming which allow the error message to be styled & obvious:

Screen Shot 2020-03-04 at 4 12 45 pm
davidpaley commented 4 years ago

This is ok, I think we can merge it buuut what I wanted to change was to put the label in red, so you show all the checkbox (in this case with the text I understand and agree.. in red). That is what I tried to and I couldn't do it.

Also there is a gap between the Required and the checkbox. This was because we were setting a margin-bottom: 2em for all checkboxes in blueprint. I commented this because I don't think we need that.

Anyway I think we should try to color all the checkbox in red for the validation @lulen11 however the error class is not applied to the label..

lulen11 commented 4 years ago

Ah!! Gotchya @davidpaley ok I will have a look again today