search

aimementoring / blueprint

This project defines some standards for all AIME platforms.
5 stars 0 forks source link

Feat/component error styles #187

Closed lulen11 closed 4 years ago

lulen11 commented 4 years ago

Hey guys,

Today I designed these new checkbox error styles that you can see in Figma. The one we're going with (until @charliemckenzie confirms) is this one:

Screen Shot 2020-03-05 at 7 28 19 pm

Then I worked on coding it into blueprint. However, I ran into some issues with CSS modules and the fact that our validation messages are in a separate component to the error container. You'll see i've left a comment in checkbox.module.scss about it on line 122. @kbardi would love to talk to you about this in the morn 'cause I'm not sure that targeting it through span span is the right way to go about it. For now, it works though so we could do a merge and release if @davidpaley wants this included for MR deployment today. (I think we should merge and then work to improve it asap).

The error should look like this in context: (Slightly diff to the design for now but again, will improve later).

Screen Shot 2020-03-05 at 7 24 18 pm
lulen11 commented 4 years ago

Thanks @rin and @davidpaley! Hey @kbardi, even though this one is all approved and merged, could we still talk about the CSS modules concerns I explained above? Either online or on zoom :)

davidpaley commented 4 years ago

Thanks @rin and @davidpaley! Hey @kbardi, even though this one is all approved and merged, could we still talk about the CSS modules concerns I explained above? Either online or on zoom :)

@lulen11 @kbardi I would like to be in that call too because I had some problems with the css, I have some doubts too maybe you can help me..

camposcristian commented 4 years ago

@lulen11 @davidpaley @kbardi could you guys record that call? Would love to have some context on this!

kbardi commented 4 years ago

Hey @camposcristianeze @davidpaley @lulen11 , yes, let's talk about it when you want...

Anyway, I created a PR with a fix for this issue https://github.com/aimementoring/blueprint/pull/190