search

aimementoring / blueprint

This project defines some standards for all AIME platforms.
5 stars 0 forks source link

Feature/no false classes #200

Closed rin closed 4 years ago

rin commented 4 years ago

Before:

Screenshot 2020-04-03 at 16 54 58

After:

Screenshot 2020-04-03 at 16 48 47
camposcristian commented 4 years ago

This looks like a great refactor :) Just for some context, is this because there were classes that we stopped to use/delete before and they're returning either null , false or undefined ?

Then, if that's the case, @kbardi maybe we can think of adding a test that runs exactly those 3 lines that Rin shared ?

rin commented 4 years ago

@kbardi Can I have a review here? And … I'm not sure how to add what Cris asked, but it would be a nice idea …?

rin commented 4 years ago

@camposcristianeze Had a quick look, and not sure how we should do the check (would probably good to check it for each rendered component individually?), so I opened a new issue for it: https://github.com/aimementoring/blueprint/issues/201