search

aimementoring / blueprint

This project defines some standards for all AIME platforms.
5 stars 0 forks source link

Global assets vs project specific assets #203

Open lulen11 opened 4 years ago

lulen11 commented 4 years ago

For a while we've been confused as to why the font was behaving weirdly on the website. I swore I had fixed this in the past but I think I had fixed it on Blueprint but not on the Website project (still unsure of the resolve on the Portal)...

Continuing on from the conversation started here: https://github.com/aimementoring/blueprint/pull/202#discussion_r416268113, and mentioned here: https://github.com/aimementoring/website/pull/368#issue-409846200, I want to raise the question to @aimementoring/engineering...

Shouldn't we have a global assets bucket so that we're not repeating assets (like fonts) (& potentially making mistakes because we have diff assets in diff projects) across the various AIME projects?

Second to this, does this only apply to fonts or should we consider other asset types like PDFs for example (such as the strategy pdf), that we would want to reference the latest copy of in both the Portal and on the Website?

camposcristian commented 4 years ago

@lulen11 could you expand why you mean by global assets? There's a single bucket that's meant to be shared with our current and most active front end projects (blueprint+website+portal)

lulen11 commented 4 years ago

@lulen11 could you expand why you mean by global assets? There's a single bucket that's meant to be shared with our current and most active front end projects (blueprint+website+portal)

hey @camposcristianeze, did you checkout the looms and start of the conversation on https://github.com/aimementoring/blueprint/pull/202 ? Within those three projects, we're repeating assets (such as the luna font) which is double up and can lead to mistakes as it has in https://github.com/aimementoring/website/pull/368 ... So by saying 'global assets', I'm suggesting a folder for "global" assets (such as fonts) that are going to be the same in all of the projects. It makes sense for (most) images to be placed in their respective frontend projects but assets such as fonts (and perhaps even pdfs), where they're the same in all of the projects, I think we should be pulling them from the one place in each of the projects. ... For example, if we want to make a change to the Luna Font in the future, and we keep it setup as it currently is, we have to upload the new font in 6 different folders/buckets aimementoring/website, aimementoring/portal, aimementoring/blueprint, aimementoring-staging/website, aimementoring-staging/portal, aimementoring-staging/blueprint...

rin commented 4 years ago

So, what I thought we were doing right now is use two global asset folders – one for staging environments and one for production (two different cloudfront links), and those are further separated into projects, like Lara said. I agree that fonts might be worth having a non-project-specific folder for (but still differentiating between staging and production, in case we change something about a font and want to see it in staging first).

Okay, I'm actually just rephrasing what @lulen11 said because she's right :) . I'd be happy to add a aimementoring/common and aimementoring-staging/common bucket.

camposcristian commented 4 years ago

hey @camposcristianeze, did you checkout the looms and start of the conversation on #202 ? Within those three projects

Sorry @lulen11 ! It was a bit late and I was on the mobile version gathering thoughts before answering :). One more question...

If blueprint is shared between both projects... Why not adding the fonts there? Then maybe in the future (if needed) we could still have specific fonts per project. At the end of the day all those fonts should come from blueprint right?