search

aimementoring / blueprint

This project defines some standards for all AIME platforms.
5 stars 0 forks source link

Add border to textarea component #204

Open mischacolley opened 4 years ago

mischacolley commented 4 years ago

Re https://aimementoring.slack.com/archives/GDJCPH517/p1588371533000100

rin commented 4 years ago

I wanted to do something about it, but to be honest I got confused.

  1. In the design system, the text area does not have a border. It just has a light blue background.
  2. I wonder if for textarea and labeledTextarea we should maybe use the same component in Blueprint, just with a prop if it has a label or not. Because in Portal MR "My Story", we're not using the labeled textarea because there's a full paragraph above the text area explaining that we want to know the story of the applicant. (So adding a label to that textarea would feel obsolete.) But right now we have textarea and labeled textarea and they are different components and they are styled differently. (Actually, in the current Blueprint style guide textarea doesn't seem to have any styles at all? http://blueprint.aimementoring.com/#textarea )

Anyway, I'm not sure what's right here – how it is supposed to look. I guess it shouldn't be white on white background with no border, but I think we might just want to add a (themed) background-color …? cc @lulen11

mischacolley commented 4 years ago

@charliemckenzie one for your Design System review to give us an answer on .... and then maybe you wanna go through the motions of making the component update as well to take it full cycle ....

rin commented 4 years ago

Hey @charliemckenzie ! Can you just let me know how the text area is supposed to look … so it's not white on white with white border anymore :) .

charliemckenzie commented 4 years ago

@rin Sorry I didn't get to this! I'd go for the same as a text input, just larger text area if that makes sense :) The one in there now is an old placeholder, as I was pulled away. But it's back on my radar now :D