The Big Input Refactor - Githubissues

aimementoring / blueprint

This project defines some standards for all AIME platforms.

5 stars 0 forks source link

The Big Input Refactor #212

Open rin opened 4 years ago

rin commented 4 years ago

Every input should …

use the validation HOC (and use the corresponding props, and tests checking for it)
have className and containerClassname (and a test checking for it)
onChangeFunction (and probably a test checking for it …?)
required prop and a visual indicator for it (and a test checking for it)
'autoFocus' (and a test checking for it)
props and styles for 'disabled' and 'readOnly' (and a test checking for them!)

Hopefully, there's something like shared examples, so we can abstract the tests for the validations, and the standard props.
Make sure we don't trigger any warnings by passing props that aren't valid HTML attributes to the HTML elements
Abstract props every input should have into defaultInputPropTypes.