Positions Form/Uploads Improvments

mischacolley commented 4 years ago

Need to:

[x] Add validation / prevent submit if supporting docs haven't been uploaded // Right now you can actually submit the form without adding anything at all, including name etc fields
[x] Submit action seems to be slow on some connections so maybe need loader to indicate something is happening

Everything is good on desktop but submitting documents on mobile is clunky. See iOS recording:

[ ] After browsing and choosing a file you get scrolled to the top of page. Should stay focused on file uploads.
[ ] ~There is no indication that you are/have uploaded a file. You have to click the button again to get the modal and then click upload file to actually submit it.~ hmmm, that's not true (says Rin), after you uploaded a file the modal closes and you see the file you have uploaded listed. I made it green so it's more obvious.
[ ] ~Couldn't click + in top corner to add second file~ This works for me (Rin)

Essentially need to keep focus on the file uploads section and reduce clicks / indicate status of upload to user. You shouldn't need to click twice.

mischacolley commented 4 years ago

@kbardi keen for you to see what you can do to improve this stuff

kbardi commented 4 years ago

Add validation / prevent submit if supporting docs haven't been uploaded // Right now you can actually submit the form without adding anything at all, including name etc fields

About this, I'm adding a validation in handleSubmit, but we don't have a toastr or snackbar, so I'm not sure how to display the error...I created a PR with the validation, but I added an error text without styles. PR https://github.com/aimementoring/website/pull/207

Also I added the loading.

I saw mobile, but I didn't have time to fix that...And also it is not a programmed behaviour some of the things you experienced, so I'm not sure how to fix them

kbardi commented 4 years ago

And some things are related to the component Bruno and David built with Uppy, so maybe it is a good idea to work with them in those issues on mobile

mischacolley commented 4 years ago

Hey @kbardi thanks for starting on this.

Re the mobile stuff. Looks like an implementation issues v a functionality issue. I just had a look at it on the portal and its functioning how I expect there. See this vid. Sorry no audio again. Essentially the model is kept open while the file uploads where as on the website as soon as you select the file the model closes and you have to re-click the upload button and then click upload file. Also on the portal I'm able to click the + to add a second file etc.

mischacolley commented 4 years ago

Re notifications. Looks like like we need to revisit the idea of adding toast etc to the website re my comments here https://github.com/aimementoring/blueprint/issues/132

mischacolley commented 4 years ago

@kbardi can you check back in on this one please 🙏🏻 The unticked checkbox items still look like they are issues. If you want to close this and break them out into their own issues.

mischacolley commented 4 years ago

@kbardi @rin still more to do here?

rin commented 4 years ago

Will look into this!

rin commented 4 years ago

So, two of the three points actually work fine for me (I can add a recording if needed), but I'm struggling to do anything about the scroll to top.

@kbardi Can I get your eyes and brains on this? https://www.loom.com/share/c3a2b1d2f6d04ab79a3fa7e7652ce533

aimementoring / website

Positions Form/Uploads Improvments #205