aimementoring / website

AIME Mentoring Website
1 stars 0 forks source link

Remove Legacy code #272

Open camposcristian opened 4 years ago

camposcristian commented 4 years ago

Originated from this comment. Thanks to @bronz3beard 's refactor using contentful and doing a quick search on code related to Craft that we've been using before, I found the following legacy components from v4 that are not being used anymore:

From Craft

Also because we don't have a Donate page anymore

I'm not sure what we did with Jobs but also this

Then it seems we have two Mentor forms? So I think we should delete this one

Annd we might have more, but this is just by quickly reviewing the code. Basically having a repo for website-v4 means we don't need to keep this here.

cc @mischacolley and @lulen11 to show a Tech Debt task that anyone can do and then it can accelerate the development or onboarding/training of anyone new to the code. I'm sure there are similar things on the CSS front.

cc @davidpaley @rin as they could provide some context on where we used this and maybe suggest other files to remove

rin commented 4 years ago

Note, I already removed the matrix builder in https://github.com/aimementoring/website/pull/271

rin commented 4 years ago

Maybe worth trying out: https://stackoverflow.com/a/60292794

mischacolley commented 4 years ago

@lulen11 one to keep in mind for Interns. I've started adding good first issue to any I think might apply.