aimementoring / website

AIME Mentoring Website
1 stars 0 forks source link

404 for existing pages #446

Open rin opened 4 years ago

rin commented 4 years ago

I guess this is more of a discussion …

How do the 404s happen that get reported on Bugnsag – I'm guessing there's not really a problem here and it's just now next.js works? But … how? Can we make these not throw Bugsnags in some way?

Bugsnag examples: https://app.bugsnag.com/aime-mentoring/website-frontend/errors/5ea8f4dff561130017a8c30c?filters[event.since][0]=30d&filters[error.status][0]=open

https://app.bugsnag.com/aime-mentoring/website-frontend/errors/5de1129a37d6bf00185d83ea?filters[event.since][0]=30d&filters[error.status][0]=open

rin commented 4 years ago

@kbardi I'm guessing this is more in your area of expertise :)

rin commented 4 years ago

@camposcristianeze @kbardi Any insights on this?

camposcristian commented 4 years ago

How do the 404s happen that get reported on Bugnsag – I'm guessing there's not really a problem here and it's just now next.js works?

@rin I guess is not next.js but just us reporting 404s AND errors using the same page?

https://github.com/aimementoring/website/blob/8a5186cf6d356672a47e5b1f39268d30dd952a8b/pages/_error/index.js#L17-L28

I created this issue to explore some solutions, but actually I think we need some sort of threshold (let's say, 100 404 hits?) on either server-side (remember server.js now is ignored with static rendering) and/or bugsnag. Maybe there's a way there to divide 404s instead of grouping them into the same "error"?

rin commented 4 years ago

this issue

@rin I guess is not next.js but just us reporting 404s AND errors using the same page? Hmm, I'm confused… do we really? So you mean the actual error is NOT a 404 but something else, but it get's caught and reported by the 404? We have an ErrorBoundary component that should do that …? cc @kbardi

camposcristian commented 4 years ago

@kbardi would be great If you can take a look during this week 👍