search

aimeos / ai-admin-jqadm

Aimeos e-commerce Vue.js+Bootstrap based admin interface
https://aimeos.org
GNU Lesser General Public License v3.0
176 stars 43 forks source link

Update item-selection.php #256

Closed Tantacula closed 1 year ago

Tantacula commented 1 year ago

Added "hidden" status for product variants.

aimeos commented 1 year ago

Thank you for your PR. What's the use case for allowing the hidden status for variant articles? Usually, they are not assigned to a category and therefore not shown at all in the frontend.

Tantacula commented 1 year ago

I'm not using this status, I just tested case when user edits variant product and sets hidden status to it and then opens "select" product which has this variant then its hidden status is not displays in this select (in "variants" section), saving function for select product returns error until variant status will be changed. I suppose select inputs for those places should be synchronized (hidden status should be removed from main form too or should be added here, but I can't just remove status which purpose I don't know)

aimeos commented 1 year ago

OK, that's a good reason :-)