search

aimeos / ai-client-html

Aimeos e-commerce HTML client components
https://aimeos.org
GNU Lesser General Public License v3.0
154 stars 58 forks source link

URL for variant product is incorrect in the basket #187

Closed defive closed 2 years ago

defive commented 2 years ago

Hi, I have noticed that the URL for variant products is incorrect in the basket.

For example the demo selection article with selected blue, 32, 34 option has the URL:

https://example.com/default/shop/demo-selection-article//2

This goes to a broken page that looks like this:

Screenshot from 2022-08-16 14-11-27

If I manually change the double-slash near the end of the URL to a single slash, the product loads as expected

aimeos commented 2 years ago

Which Aimeos version are you using?

defive commented 2 years ago

I'm on dev-master as I was told this is necessary for the marketplace extension

aimeos commented 2 years ago

Only if you need something brand new, otherwise ~2022.07 would be OK too.

Think we've found the problem in the common/summary/detail.php template: https://github.com/aimeos/ai-client-html/commit/00593bb4da0875db11a15025954e3def6d49809f

Can you check if it works for you too?

defive commented 2 years ago

Okay, the double slash is still in the URL, but the id seems to be correct so it works.

Thanks for your quick response!

Also thank you for the info regarding versions. I will switch to 2022.07 as I would rather receive less updates when running composer up.

aimeos commented 2 years ago

Great! The patch is now in 2022.07.x-dev too