aimeos / ai-cms-grapesjs

GrapesJS CMS integration into Aimeos
GNU Lesser General Public License v2.1
22 stars 18 forks source link

New container box height #15

Closed Ameeko closed 2 years ago

Ameeko commented 2 years ago

Hello!

I created a container image The height of the container box is very small, it is difficult to insert an item.

Is there a way to make this box higher by default?

aimeos commented 2 years ago

You seem to have a monitor with a very high resolution. Can you experiment a bit by adding:

.container-xl {
    min-height: 2.5rem !important;
    height: 5vh;
}

The first line is already there and you should set the value of height to an appropriate value.

Ameeko commented 2 years ago

Thanks for the reply.

The .container-xl class is also used by the website, so I put this in aimeos.css: .gjs-dashed .container-xl {

I copied the CSS code to aimeos.css in my own theme, but the admin will definitely take the CSS from the default theme folder in this IFRAME. image

How do I set this IFRAME to use the CSS of my own theme, just like a website? image

aimeos commented 2 years ago

What's the optimal height value now?

The height of the container shouldn't be added to the frontend CSS because there it's likely to be unwanted. Instead, the CSS for the editor must be added here: https://github.com/aimeos/ai-cms-grapesjs/blob/master/admin/jqadm/themes/custom.js#L636-L670

The GrapesJS code isn't prepared yet to use the theme CSS. To support themes, adding a "data-theme" attribute in the template and pushing the CSS location by JS here would be the best option: https://github.com/aimeos/ai-cms-grapesjs/blob/master/admin/jqadm/themes/custom.js#L98-L103

Ameeko commented 2 years ago

I understand, but

1) If I set a fixed height for the container, it will always be that height when editing. The elements placed in the container will be higher than the height of the conatiner. This is not good. Increasing the min-height to 5rem would be better.

2) I modified the underlined parts for testing in the /vendor/aimeos/ai-cms-grapesjs/admin/jqadm/themes/custom.js file, but none of them affected it:

image

Only these affect the container element: image

I searched for it, I rewrote it everywhere. I also deleted my cache. So I do not understand. Does it still take data from some cache?

aimeos commented 2 years ago

CSS needs to be component specific now like for the cataloglist component. This is changed in the latest commit:

composer req aimeos/ai-cms-grapesjs:2021.10.x-dev
Ameeko commented 2 years ago

Works better after the update. Thanks.