aimeos / ai-controller-jobs

Aimeos e-commerce job controllers
https://aimeos.org
GNU Lesser General Public License v3.0
28 stars 17 forks source link

use configurable absolute url for sitemap locations in index file #18

Closed s-diez closed 5 years ago

s-diez commented 5 years ago

See https://github.com/aimeos/ai-controller-jobs/issues/17

As this option is necessary and no default make sense, i added the same behavior as for location.

aimeos commented 5 years ago

The same applies to the product sitemap index file as well, doesn't it? Can you please use baseurl instead of base-url to be in line with the other settings?

s-diez commented 5 years ago

The same applies to the product sitemap index file as well, doesn't it?

Yes the PR contains both.

Can you please use baseurl instead of base-url to be in line with the other settings?

Done

aimeos commented 5 years ago

Does it make sense to add a common sitemap baseurl setting so users don't need to set both? For example, in the TYPO3 scheduler task there should be a possibility to enter one URL and that value is required when saving the task.

s-diez commented 5 years ago

Only one setting would be easier, but maybe not as flexible. The URL most likely corresponds to the "location" setting. I think we would then need to change this to a common setting too.

Regarding the scheduler task, the task handles many jobs so enforcing this setting when the user does not actually want a sitemap job is kinda weird. Again similar to the location setting which is required for the sitemap jobs but has to be set through the option "TypoScript Konfiguration". Maybe it would be possible to add fields depending on the selected jobs or at least change the validation to required depending on jobs?

aimeos commented 5 years ago

You are right, the location needs to be set nevertheless