2019.10 - Githubissues

aimeos / ai-controller-jobs

Aimeos e-commerce job controllers

https://aimeos.org

GNU Lesser General Public License v3.0

112 stars 17 forks source link

Closed tyteck closed 2 years ago

tyteck commented 4 years ago

Hello As discussed here I've added the possibility to link a product to a supplier during the import.

It is working on my project but :

it is my first pull request on the open source world
I'm not familiar with phing and I failed to make it run properly on this project.
I didn't write any unit test to valid the feature

In consequence I'm expecting a reject with the things I can improve. Thanks for reading.

aimeos commented 4 years ago

Thank you very much for your pull request, we really appreciate it! :-)

Your work is very good for the first try. First, you need to comply to the Aimeos coding standard which is checked in the tests. You can see the violations e.g. here: https://travis-ci.org/github/aimeos/ai-controller-jobs/jobs/682838765

It's a big PR and we usually don't add such big changes to the 2019.10 LTS branch. Can you please create one for the master branch?