aimeos / ai-controller-jobs

Aimeos e-commerce job controllers
https://aimeos.org
GNU Lesser General Public License v3.0
28 stars 17 forks source link

FIX | fix wrong syntax in $baseRef array #3

Closed merzilla closed 6 years ago

merzilla commented 6 years ago

Change the dots to slashes, so the $order->coupons array is filled and in the export with the default mapping, the coupon code is written to CSV file.

aimeos commented 6 years ago

Your fix needs a change in the test as well. Can you please adapt the test too? https://travis-ci.org/aimeos/ai-controller-jobs/jobs/356956734

merzilla commented 6 years ago

I'm going to adapt the test, too. But I have some problems: I've installed phing and phpunit so far. In the TestHelperJobs.php I had to enter the absolute path to Bootstrap.php in the getAimeos(). Now the problem is that all 125 Tests try to connect to DB which is not there. The EXT has no phing setup command. I'm using aimeos as TYPO3 extension, installed with composer. How can I run the tests? Thx for help in advance.

Edit: Here is one of the 125 errors: 1) Aimeos\Controller\Jobs\Admin\Cache\FactoryTest::testCreateController Aimeos\MW\DB\Exception: SQLSTATE[HY000] [1045] Access denied for user ''@'localhost' (using password: NO)

aimeos commented 6 years ago

For running the tests, you need to checkout the Aimeos core (git clone) and the extension into the ./ext/ folder. Then, create the ./config/resources.php from the template file in this directory. Afterwards, you can execute phing setup and phing test or phing -Ddir=ext/ai-controller-jobs testext

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 96.126% when pulling 40e75d7f30b7c48b1ec768b49b26ac4e4b40f199 on merzilla:merzilla-patch-fix-csv-export-with-coupon-code into c4b4dcc160c94374070fcf0fc8be588ba1c838de on aimeos:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 96.126% when pulling 40e75d7f30b7c48b1ec768b49b26ac4e4b40f199 on merzilla:merzilla-patch-fix-csv-export-with-coupon-code into c4b4dcc160c94374070fcf0fc8be588ba1c838de on aimeos:master.

aimeos commented 6 years ago

Thanks a lot! :-)