search

aimeos / aimeos-core

Aimeos PHP e-commerce framework for ultra fast online shops, scalable marketplaces, complex B2B applications and #gigacommerce
https://aimeos.org
Other
3.4k stars 118 forks source link

Fix wrong position bug in editProduct() #167

Closed nvindice closed 5 years ago

nvindice commented 5 years ago

Fixed a bug in editProduct() where the $pos variable was overwritten too early. If there is no matching product in the basket (don't know when this should occur, but it does together with the bug above), the edited item would get stored at position 0 (resulting from return false). This results in duplicated or overwritten basket items.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.006%) to 91.193% when pulling dd03ea5bc05e333067cd65cf8ed2fe964abec548 on nvindice:2018.10 into 36702575f33c93c934a05db87123089fffa53702 on aimeos:2018.10.

aimeos commented 5 years ago

Thanks!