aimeos / aimeos-core

Aimeos PHP e-commerce framework for ultra fast online shops, scalable marketplaces, complex B2B applications and #gigacommerce
https://aimeos.org
Other
3.4k stars 118 forks source link

Add configuration option to progress delivery status automatically #168

Closed nvindice closed 5 years ago

nvindice commented 5 years ago

Currently, the delivery status is changed to "in progress" as soon as the payment is recieved. I've added a configuration option to prevent this behaviour if a shop owner wants to control this process manually. What do you think?

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.6%) to 90.549% when pulling 56e0e701199f8bfa83b30cb5a8aaba543c576385 on nvindice:2018.10 into 62c3715e4b1edd6e8e1cdbdc9c81ca0155e7a543 on aimeos:2018.10.

aimeos commented 5 years ago

We can set the status to STAT_PENDING by default because it would make sense. But we can't leave it to STAT_UNFINISHED because that job controller relies on the status: https://github.com/aimeos/ai-controller-jobs/blob/master/controller/jobs/src/Controller/Jobs/Order/Service/Delivery/Standard.php#L113

Also, this is not an acceptable change for the LTS version.

nvindice commented 5 years ago

I agree, STAT_PENDING makes much more sense than STAT_UNFINISHED. How yould you like me to implement this? Because 2018.10 is a LTS, as you pointed out, I would prefer to use a configuration option instead of changing the default value, as some existing systems like ERP chains etc may rely on STAT_PROGRESS.

I could a) define the status via a configuration option like mshop/service/provider/delivery/default-status = STAT_PENDING b) make a configuration option like mshop/service/provider/delivery/default-status-pending = 1

Any other ideas?

aimeos commented 5 years ago

Create a new delivery service provider which sets the status to your needs and configure it's name in the service panel instead of Standard. Happy to accept a PR that changes the status STAT_PENDING in the master branch :-)

nvindice commented 5 years ago

Okay. I understand you don't want to change anything in 2018.10, I will create a provider for it. PR for 2019.x is created.