search

aimeos / aimeos-core

Aimeos PHP e-commerce framework for ultra fast online shops, scalable marketplaces, complex B2B applications and #gigacommerce
https://aimeos.org
Other
3.4k stars 118 forks source link

Setting service config with Jsonadm #195

Closed matteovg7 closed 4 years ago

matteovg7 commented 4 years ago

Change to cast the JSON object of config came from Jsonadm into array.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.1%) to 88.409% when pulling 287f2c71842c7a426f4d207c97aec08f3fa56742 on matteovg7:patch-1 into 38a3a3065ab3f12b5ae5ff1a0986ad145bb19bae on aimeos:master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.1%) to 88.409% when pulling 287f2c71842c7a426f4d207c97aec08f3fa56742 on matteovg7:patch-1 into 38a3a3065ab3f12b5ae5ff1a0986ad145bb19bae on aimeos:master.

aimeos commented 4 years ago

Wouldn't it be better to enforce an array in the JsonAdm package?

matteovg7 commented 4 years ago

Ok I created a PR in the JsonAdm package.