search

aimeos / aimeos-core

Aimeos PHP e-commerce framework for ultra fast online shops, scalable marketplaces, complex B2B applications and #gigacommerce
https://aimeos.org
Other
3.4k stars 118 forks source link

missing directory exists check #217

Closed xerc closed 3 years ago

xerc commented 3 years ago

@ ext/test/manifest.php

   'setup' => ['lib/custom/setup']

$ php artisan aimeos:setup breaks if folder wihin EXT path is missing; ext/test/lib/custom/setup https://github.com/aimeos/aimeos-core/blob/eb2e68fe2f0bfb73c8ac806b9fa24ef2db6a9b85/lib/mwlib/src/MW/Setup/Manager/Base.php#L120

aimeos commented 3 years ago

We could add a file_exists() check here but this could lead to hard to find errors if the entry in the manifest.php or the setup directory are not named the same (e.g. due to a spelling issue). Thus, we made sure that there's a .gitkeep file in lib/custom/setup for newly created extensions, so this directory isn't a problem when you check out the extension from a Git repository (which doesn't create empty directories).