search

aimeos / aimeos-core

Aimeos PHP e-commerce framework for ultra fast online shops, scalable marketplaces, complex B2B applications and #gigacommerce
https://aimeos.org
Other
3.4k stars 118 forks source link

Sanitize the url segment before saving product item #248

Closed niloofarfs closed 3 years ago

aimeos commented 3 years ago

Can you please adapt the necessary tests too? https://app.circleci.com/pipelines/github/aimeos/aimeos-core/553/workflows/c1c8d8ff-1494-4115-ae6b-55fd577a126e/jobs/2352

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 85.896% when pulling 0485b04d52142a0b1e3c3d166aea637de0b22474 on niloofarfs:master into a4bfdb043bfcbc95ccf920962a622dc45063d8c5 on aimeos:master.

niloofarfs commented 3 years ago

Can you please adapt the necessary tests too? https://app.circleci.com/pipelines/github/aimeos/aimeos-core/553/workflows/c1c8d8ff-1494-4115-ae6b-55fd577a126e/jobs/2352

If underline is not a valid character in url segments, I could change the tests. Should I stay whith this approach or simply change tset?

aimeos commented 3 years ago

Underline is a valid character and your change is OK. Thanks a lot!