search

aimeos / aimeos-core

Aimeos PHP e-commerce framework for ultra fast online shops, scalable marketplaces, complex B2B applications and #gigacommerce
https://aimeos.org
Other
3.38k stars 116 forks source link

Add mimetypes for audio (mp3, ogg, weba) and epub #305

Closed rowild closed 1 year ago

rowild commented 1 year ago

Required for allowing an audio display (audio player) in the media fields of ai-admin-jqadmin.

rowild commented 1 year ago

This is required for another commit in ai-admin-jqadm. But since this commit has consequences (and the other is not yet finished), I would prefer to discuss the addition of mimetypes first. Mainly, because at some point images are compared against an IFace, something which does not exist for video not audio. Not sure if this is required.

coveralls commented 1 year ago

Coverage Status

Coverage: 90.678% (+0.001%) from 90.677% when pulling 43c45df2c4a9c33e6977c507584c7ba3bf6d906f on rowild:rowild-add-mimetypes into 2561d59c3a34a119785851bc17a8e95dbd42620b on aimeos:master.

aimeos commented 1 year ago

Thank you for your PR! It looks good and could be merged without problems

rowild commented 1 year ago

Ok, in the other commit you said it is not a problem to not have IFaces for audio and video. So I convert it back from draft and if you will, you could merge it.