aimeos / aimeos-typo3

TYPO3 e-commerce extension for ultra fast online shops, scalable marketplaces, complex B2B applications and #gigacommerce
https://aimeos.org/TYPO3
GNU General Public License v3.0
274 stars 738 forks source link

Upgrade Wizard overwrites existing extension configuration #213

Closed DanielSiepmann closed 6 months ago

DanielSiepmann commented 6 months ago

We run upgrade:run on every deployment. That will always trigger the provided upgrade wizard Setup. That's fine. The actual issue is the code within the wizard:

$extconf->set('aimeos', ['useDemoData' => '']);

This code does replace the whole extension configuration, not only the useDemoData setting. The behaviour seems to be broken since TYPO3 v11 support of EXT:aimeos.

TYPO3 allowed to set individual options prior v11. Since v11 only full configuration is supported via API.

aimeos commented 6 months ago

Thanks for the hint and providing a PR. It has been merged now and your PR will be backported and available in the next release.

DanielSiepmann commented 6 months ago

Thanks for the fast response :)