Update Payone.php - Githubissues

aimeoscom / ai-payments

Payment provider extension for Aimeos web shops and e-commerce solutions

https://aimeos.org/

GNU Lesser General Public License v3.0

19 stars 18 forks source link

Update Payone.php #16

Closed creativemadeofficial closed 5 years ago

coveralls commented 5 years ago

Coverage remained the same at 73.056% when pulling 1f3e4a650a6d2e6539496963c3cf39d55477c729 on creativemadeofficial:patch-1 into 3f3f80f024bb4b443742902829195818822d7ff7 on aimeoscom:master.

aimeos commented 5 years ago

Thank you for your PR! One thing: $completePrice is overwritten each time instead of summing up the values. Can you fix that?

creativemadeofficial commented 5 years ago

should be ok like this because (string) ( (float) $delivery->getPrice()->getCosts() + (float) $completePrice ); adds up himself

aimeos commented 5 years ago

Sorry, haven't seen that. Thanks