search

aimeoscom / ai-payments

Payment provider extension for Aimeos web shops and e-commerce solutions
https://aimeos.org/
GNU Lesser General Public License v3.0
19 stars 18 forks source link

Update Stripe.php #21

Closed tenkraD closed 5 years ago

tenkraD commented 5 years ago

Mount JS Stripe Elements to a div

aimeos commented 5 years ago

We've changed the type to "container" now in ai-client-html so it's independent of the actually used tag. Furthermore, you shouldn't change dash in the keys to dot ("-" vs. ".") because dots in tag IDs are problematic and for the selectors, you should use "#process-payment-cardno" instead of "div[id=...]".

Can you change that? Afterwards, we will be happy to merge your PR :-)

tenkraD commented 5 years ago

If u dont use payment.cardno the label field will not be translated.

I think if you use - instead of . the language translation must be corrected

aimeos commented 5 years ago

Good point. After having a look into the HTML specs, dots are allowed in ID attributes. Only question left: Does #process-payment.cardno work or only div[id="process-payment.cardno"]?

tenkraD commented 5 years ago

No #process-payment.cardno dosen't work. I tried it before cause it would be the easier selector to understand.

Just div[id="process-payment.cardno"] works cause of the point.

aimeos commented 5 years ago

OK, then we have to leave this as is. Can you change the type from div to container? Then we will merge your PR

tenkraD commented 5 years ago

I changed it, do i have to do a new pr?

aimeos commented 5 years ago

Thanks. Your PR has been automatically updated

aimeos commented 5 years ago

Your PR has been merged into 2018.10 too and a new release tagged