FIX/PATCH PROVIDED: webshell freezes because of uncaught exceptions during closed session cleanup

What steps will reproduce the problem?
1. start webshell on a terminal and monitor its output
2. login through webshell
3. logout
4. repeat w few times
5. wait a couple of minutes

What is the expected output? What do you see instead?

Webshell should clean up the closed sessions and their respective 
processes.

Instead, the processes hang there.
The main webshell process reports some exceptions about non existing 'fd' 
key when del-ing an entry from a dictionary.

What version of the product are you using? On what operating system?

Webshell-0.9.5 on Ubuntu 8.04

Please provide any additional information below.

The problem is that after a session is closed, webshell tries to clean up 
some data structures (the session dictionary). It tries to delete some 
entries without checking whether they exist. When it tries to delete non 
existing entries, an unhandled exception is thrown and that particular 
webshell process freezes.

In my case, I can only log in a couple of times initially, then the whole 
webshell service hangs and is unusable.

The solution of this problem is to check whether a dictionary entry exists 
before trying to delete it. The patch that fixes this is attached.

After applying this patch I were able to work normally with webshell.

Original issue reported on code.google.com by aleksand...@gmail.com on 1 Oct 2008 at 1:39

Attachments:

webshell.py-freeze_fix.patch

aimeyzie / web-shell

FIX/PATCH PROVIDED: webshell freezes because of uncaught exceptions during closed session cleanup #43