search

aimhubio / aim

Aim 💫 — An easy-to-use & supercharged open-source experiment tracker.
https://aimstack.io
Apache License 2.0
4.93k stars 297 forks source link

[feat] Add a filesystem-based backend for artifact storage #3156

Closed gpascale closed 1 week ago

gpascale commented 3 weeks ago

Adds FilesystemArtifactStorage, a local filesystem-backed implementation of AbstractArtifactStorage, and adds it to the registry.

Works very similarly to S3ArtifactStorage, except you would pass a url like file:///path/to/artifacts as the uri.

CLAassistant commented 3 weeks ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

gpascale commented 3 weeks ago

I was interested in this, and saw a few issues (#3144, #3139) mentioning it as well, so I thought I'd see if I could implement it. It seems to be working in my very simple setup, but I haven't done that much testing.

Curious for feedback from maintainers as to whether this looks like the correct approach or not.

alberttorosyan commented 2 weeks ago

@gpascale I've pushed changes in CHANGELOG.md. Please complete the CLA so we can proceed with merge.

alberttorosyan commented 1 week ago

@gpascale closing this PR as the CLA is a mandatory step. Will commit changes on your behalf in #3164

gpascale commented 1 week ago

@alberttorosyan Ah sorry for going dark on this. I was travelling the past few weeks and not checking things. Glad to heard you've gotten the feature in!