15/n remove local videos and reuse display video code

aimpowered / LibOrate

A videoconferencing companion app developed by AImpower.org to provide emotional and relational support during videoconferencing.

https://liborate-alpha.vercel.app

MIT License

0 stars 2 forks source link

15/n remove local videos and reuse display video code #22

Closed kexinF closed 9 months ago

kexinF commented 9 months ago

@blickly Hi Ben, based on the discussion today, it is inefficient to amend the old code we no longer use after switching to tab. As a result, I am submitting a new PR which is based on the new code but reflects your feedback.

Shaomei commented 9 months ago

Wow this PR is huge.. @kexinF, you need to break it down to small pieces for us to be able to review it in a reasonable time..

kexinF commented 9 months ago

Wow this PR is huge.. @kexinF, you need to break it down to small pieces for us to be able to review it in a reasonable time..

@Shaomei No, this did not have this much change compared with 14/n. I guess we messed up with the main branch when we did the rebase, that's why it appeared to have so many commits compared with the main.