aimpowered / LibOrate

A videoconferencing companion app developed by AImpower.org to provide emotional and relational support during videoconferencing.
https://liborate-alpha.vercel.app
MIT License
0 stars 2 forks source link

Make sure the nametag appear in the bottom right corner of user foreground #44

Closed Shaomei closed 1 month ago

Shaomei commented 7 months ago

Currently, the nametag seems to be floating:

Screenshot 2024-04-17 at 9 31 22 AM

But per design, it should appear in the bottom right corner:

Screenshot 2024-04-17 at 9 34 15 AM
Shaomei commented 7 months ago

It seems that the name tag moves when someone turn off and turn on the video again.

Shaomei commented 6 months ago

@kexinF Can you look into this? I think the change should happen inside functiondrawEverythingToImage in lib/draw_badge_api.ts file.

I actually sometimes have trouble seeing the nametag badge at all, and will only see it after turning off and turning on my video (it will appear in the middle). I suspect the original placement is outside my window size. Can you make the position and size of the nametag relative to the user's window size?

kexinF commented 6 months ago

Some other developers also had similar problem: https://devforum.zoom.us/t/how-to-get-the-actual-size-of-the-video-rendered-in-canvas-because-i-found-that-the-size-specified-in-rendervideo-is-not-the-actual-rendered-width-and-height/54258/4 https://devforum.zoom.us/t/how-to-get-user-users-screen-size-to-draw-things/87912/6

I tried to detect the camera size using getmedia: https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia It worked in the browser, but I don't think zoom app browser supports it.

Let's discuss other possible solutions in the meeting. @Shaomei

Shaomei commented 2 months ago

This is fixed by PR #90