search

aimpowered / LibOrate

A videoconferencing companion app developed by AImpower.org to provide emotional and relational support during videoconferencing.
https://liborate-alpha.vercel.app
MIT License
0 stars 2 forks source link

Refactor Hand Wave component(s). #61

Closed Shaomei closed 6 months ago

Shaomei commented 6 months ago
  1. Add a WaveHandPicker Component to keep track of which handwave button is selected;
  2. When a button is selected or unselect, the WaveHandPicker will create a new HandWaveBadge that is to be re-rendered by the root (App) component.
  3. Get rid of the handwave button states at the App level, we only need to keep track of the selectedButtonId inside the WaveHandPicker component.
  4. also included a small change to NameTagForm that adds a title.

This PR also fixed current bug that the clicked button and displayed badge are out-of-sync. See screenshot below:

Screenshot 2024-04-26 at 10 45 51 PM
vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zoom-companion-shaomei-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2024 4:05pm
zoom-companion-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2024 4:05pm
Shaomei commented 6 months ago

FYI @kexinF @BrennanJones

Shaomei commented 6 months ago

@blickly, thanks for the initial review. I have addressed all your comments. Let me know if you see anything else I should change.