search

ain / smartbanner.js

Customisable smart app banner for iOS and Android
https://npmjs.com/package/smartbanner.js
GNU General Public License v3.0
621 stars 178 forks source link

Unexpected token ')' when close banner #642

Closed jonayrodriguezmrf closed 1 year ago

jonayrodriguezmrf commented 1 year ago

Steps to reproduce:

  1. Click on close icon

What happens: When I click the close button, I get the error SyntaxError: Unexpected token ')', and it doesn't close. The next time, it closes

What should happen: Close without error.

The problem is in the javascript:void(); It's missing the 0, javascript:void(0); https://github.com/ain/smartbanner.js/blob/main/src/smartbanner.js#L136

ain commented 1 year ago

This is almost certainly the implementation issue of bundling smartbanner's source code (release code is tested and linted) in 3rd party applications, but since the change is harmless and could potentially avoid the problems you describe, there will be a release changing this.