ainfosec / FISSURE

The RF and reverse engineering framework for everyone. Follow and ★ to show your support!
https://twitter.com/FissureRF
GNU General Public License v3.0
1.56k stars 85 forks source link

Python3-3.10 some quick fixes for some Quality of Life Issues #39

Closed trwbox closed 9 months ago

trwbox commented 1 year ago

These fixes were all made and tested on the Python3-3.10 branch, but I have no reason to believe the same ideas can't be applied to the Python3-3.8 branch as well. I just do not have a system setup with that I can test them on.

Changes:

Most of these may occur more times in the program, these are ones I happened to run into while poking around, and could get narrowed down quickly.

cpoore1 commented 1 year ago

I will investigate these points with more detail in a bit. Here are my initial thoughts:

  1. The Logs directory should always be there. If the goal is to move it somewhere else, test pieces without it, or rename it, then most of those changes could be done. The logging.yaml file does include the Logs/event.log location and the dashboard.py code points to the Logs/event.log file without pulling it from any yaml/configuration file in a couple places. The logging mechanism needs updating in a bunch of areas.
  2. I will look into applying validators on a broader scale for the user inputs.
  3. I definitely will insert checks to only accept valid port ranges.
  4. I have no problem with adding common troublesome extensions to .gitignore. Although, I'm curious if anyone is editing this or including secondary files while on MacOS.
  5. I'll test out the graceful closing. That really needs to be fixed to prevent annoying kill/pkill commands on crashes. Plus the killing of the other programs can cause a select number of people to log out. It is complicated a little by the fact that the components were designed to be run on different computers across a network. I have not tested each component away from localhost in a long time and that should be looked at again.
  6. There are essentially no checks in place if menu items are not installed and accessed within the menu. Those will be added where possible going forward.