search

aino-komal / mvp4g

Automatically exported from code.google.com/p/mvp4g
0 stars 0 forks source link

Multiple presenter failed to inject itself to the enclosed reverse view #115

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

1. Root Presenter (RP) has a VerticalPanel (VP).

2. Presenter (P) has a Reverse View (RV), and is configured as Mvp4g multiple 
presenter.

http://code.google.com/p/mvp4g/wiki/PresenterViewService#Multiple_presenter

3.RV has a Button (B) that delegates ClickEvent handling to P.

4. Two instances of P and RV (p1, p2, rv1, rv2) are created, then rv1 and rv2 
are added to VP, so the browser shows both of them.

5. Click either of the buttons, NPE is caught because of null p1 or p2.

What is the expected output? What do you see instead?

Multiple presenter should inject itself to the enclosed reverse view as single 
presenter does.

What version of the product are you using? On what operating system?

1.4.0

Please provide any additional information below.

Workaround:

Exposing ReverseView#setPresenter to the multiple presenter, manually call 
setPresenter(this) to pass it to the enclosed reverse view.

See also:

https://groups.google.com/forum/?fromgroups#!topic/mvp4g/IhjO7T7VlCU

Original issue reported on code.google.com by fans.gro...@googlemail.com on 1 Jul 2012 at 12:10

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Probably the injection of multiple presenter to its enclosed reverse view is in 
the charge of Mvp4g EventBus, isn't it?

Original comment by fans.gro...@googlemail.com on 1 Jul 2012 at 2:04

GoogleCodeExporter commented 9 years ago 
Here is a lib containing a fix for this issue. Would you mind testing it and 
check if it corrects your issue? Thanks

Original comment by plcoir...@gmail.com on 4 Jul 2012 at 2:15

Attachments:

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r1485.

Original comment by plcoir...@gmail.com on 5 Jul 2012 at 1:56

GoogleCodeExporter commented 9 years ago 
Retested successfully.

Original comment by fans.gro...@googlemail.com on 7 Jul 2012 at 9:13

GoogleCodeExporter commented 9 years ago 
Even if i choose "all issues" under http://code.google.com/p/mvp4g/issues/list, 
 only 25 "open issues" display . i have to search this issue 115 to see it. How 
to get all issues listed?

Original comment by fans.gro...@googlemail.com on 7 Jul 2012 at 9:23

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Thanks for validating the fix.

There is a 'next' button on the top right of the list to go to the next page.

Original comment by plcoir...@gmail.com on 9 Jul 2012 at 8:24