search

aino-komal / mvp4g

Automatically exported from code.google.com/p/mvp4g
0 stars 0 forks source link

Multi level Inheritance #25

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I've small problem with Mvp4g. I would use more than one level inheritance.
Let's imaginate that we have a complex application. To avoid creation of
huge event buses we create following buses:

ApplicationEventBus (some common events like login, logout)
`- FrameEventBus (master view)
   `- DashboardEventBus (detail view)

Root cause of problem is declaration of "itself" field in generated
modules. They use Mvp4gModule instead of "self" type.

I made patch to change field type to current class name. It's very simple.
Regards,
Luke

Original issue reported on code.google.com by lukasz.d...@gmail.com on 30 Mar 2010 at 12:48

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi Luke,

I'm not sure I understand your problem. You said you had an issue with event 
bus 
inheritance but I'm not sure to see what was your issue and how your changes 
solved 
it. Could you give me more details?

Thanks,
Pierre

Original comment by plcoir...@gmail.com on 30 Mar 2010 at 1:06

GoogleCodeExporter commented 9 years ago 
Hello Pierre,
My problem is as follows - the second (and every next) level of inheritance 
does not
work. So we can have parent and child module/bus but can't have children of the 
child
(for example DashboardEventBus) because Mvp4gGenerator creates code which will 
not
compile.
Reason why code will not compile: declaration of itself field with type 
Mvp4gModule.
On the second and next level "itself" should point to child module, instead 
generic
class.
I checked examples and they don't contain 3 level inheritance, so you can't 
find this
bug.

Regards,
Luke

Original comment by lukasz.d...@gmail.com on 30 Mar 2010 at 3:32

GoogleCodeExporter commented 9 years ago 
Thanks for the clarification. I now understand the problem. 

Thanks also for the correction, I will add them to the next version.

Original comment by plcoir...@gmail.com on 30 Mar 2010 at 5:32

GoogleCodeExporter commented 9 years ago 
Part of the last snapshot

Original comment by plcoir...@gmail.com on 8 Apr 2010 at 1:18

GoogleCodeExporter commented 9 years ago 
Issue 32 has been merged into this issue.

Original comment by plcoir...@gmail.com on 13 Sep 2010 at 5:16