search

ainslec / adventuron-issue-tracker

Adventuron Issues Tracker
4 stars 0 forks source link

Improvement: Ambient sounds clipped when changing locations #234

Open hnejfnvjojgrogjwm opened 3 years ago

hnejfnvjojgrogjwm commented 3 years ago

Note: I know sound is still experimental and maybe this issue makes no sense or gets outdated soon. Anyway I prefer to report it as a reference because we are talking about too many issues in the chat on a regular basis and it is easy to forget about them.

When using ambient sound in zones (e.g. the same engines sound in every room of a spaceship), when moving from one location to another the ambient sound restarts, creating a slightly clipped noise.

For the same sound effect in a zone: Please implement the feature that when Adventuron receives a request to play a sound and detects that that sound is already being played, it does nothing.

For different sound effects between locations: Please implement the feature that when Adventuron receives a request to play a sound and there is another sound already playing, creates a transition blending both sounds, or fade out the first one and fade in the next one, to avoid the sharp cut.

ainslec commented 3 years ago

Please try beta 66e.

hnejfnvjojgrogjwm commented 3 years ago

I am testing it right now. The sound in the same zone now plays without cuts, so that is at least half of the problem solved. When I move from one location with one ambient sound to another location with a different ambient sound, sometimes I can hear a crackle. Moreover I found another issue: A sound that should have a smooth loop (as it is when I play it in Audacity) sounds clipped every time reaches the end of the loop. Please find the audio file here: https://www.dropbox.com/s/8agwrjji95d7nrk/engines02.wav?dl=0

ainslec commented 3 years ago

Please can you supply some sample source code to demonstrate this issue?

hnejfnvjojgrogjwm commented 3 years ago

sound_test.zip

Please execute this little code. The sound ambient in the first room is very short, so you will notice the cut at the end immediately. Check the other sounds too. In this test I can not reproduce the crackle when moving between rooms. Maybe is related to the size of the file. Anyway it wasn't very big.