aio-libs / aiobotocore

asyncio support for botocore library using aiohttp
https://aiobotocore.aio-libs.org
Apache License 2.0
1.16k stars 182 forks source link

Remove confusing `aiobotocore.session.Session` symbol #1047

Closed jakob-keller closed 10 months ago

jakob-keller commented 10 months ago

Description of Change

Rename import of botocore.session.Session in aiobotocore.session to mark it private.

Assumptions

aiobotocore.session.Session was never intended to become part of public API.

Checklist for All Submissions

codecov[bot] commented 10 months ago

Codecov Report

Merging #1047 (075c980) into master (71bb001) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1047   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files          60       60           
  Lines        5805     5807    +2     
=======================================
+ Hits         5015     5017    +2     
  Misses        790      790           
Flag Coverage Δ
unittests 86.39% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aiobotocore/session.py 79.24% <100.00%> (+0.39%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

thehesiod commented 10 months ago

hrm, github resolve isn't so great

thehesiod commented 10 months ago

feel free to re-merge and force push up

jakob-keller commented 10 months ago

feel free to re-merge and force push up

CI is running 🤞🏻