aio-libs / aiobotocore

asyncio support for botocore library using aiohttp
https://aiobotocore.aio-libs.org
Apache License 2.0
1.16k stars 182 forks source link

Support up-to-date `botocore` #1048

Closed jakob-keller closed 10 months ago

jakob-keller commented 10 months ago

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by relaxing the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

Upstream diff does not contain any changes that require adjustments to the aiobotocore codebase. This allows for the proposed widening of the botocore dependency specification.

Checklist for All Submissions

Checklist when updating botocore and/or aiohttp versions

jakob-keller commented 10 months ago

I intend to monitor botocore releases and regularly push updates until it is worth merging this PR.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f67503a) 86.39% compared to head (7d996f4) 86.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1048 +/- ## ======================================= Coverage 86.39% 86.39% ======================================= Files 60 60 Lines 5807 5807 ======================================= Hits 5017 5017 Misses 790 790 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiobotocore/pull/1048/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aio-libs/aiobotocore/pull/1048/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `86.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thehesiod commented 10 months ago

ok let me know when you want to merge

thehesiod commented 10 months ago

want to convert to draft meanwhile?

jakob-keller commented 10 months ago

I suggest we merge now and extend support to include botocore==1.31.70.

botocore==1.31.71 might be a little bit more involved due to https://github.com/boto/botocore/pull/3037.