aio-libs / aiobotocore

asyncio support for botocore library using aiohttp
https://aiobotocore.aio-libs.org
Apache License 2.0
1.16k stars 182 forks source link

Support up-to-date `botocore` #1057

Closed jakob-keller closed 9 months ago

jakob-keller commented 9 months ago

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by bumping the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

Upstream diff contains several minor changes that affect this codebase.

Checklist for All Submissions

Checklist when updating botocore and/or aiohttp versions

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (281e68d) 86.39% compared to head (7b70394) 86.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1057 +/- ## ========================================== + Coverage 86.39% 86.46% +0.06% ========================================== Files 60 60 Lines 5807 5814 +7 ========================================== + Hits 5017 5027 +10 + Misses 790 787 -3 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiobotocore/pull/1057/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aio-libs/aiobotocore/pull/1057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `86.46% <100.00%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jakob-keller commented 9 months ago

@thehesiod: This PR adds support for a whole bunch of new and updated AWS services that are released during re:Invent 2023. I suggest to do a release soon to maintain feature parity.

botocore>=1.33.2 includes many new codepaths and will likely be a major piece of work for us. This will need to be worked on in another PR.

thehesiod commented 9 months ago

that's so awesome you added link to diff. We need to add that to the template in the checklist with example

thehesiod commented 9 months ago

looks great, thanks!