Closed jakob-keller closed 9 months ago
Attention: 23 lines
in your changes are missing coverage. Please review.
Comparison is base (
1ce6853
) 86.46% compared to head (ef378b7
) 86.13%.
Files | Patch % | Lines |
---|---|---|
aiobotocore/utils.py | 45.16% | 17 Missing :warning: |
aiobotocore/signers.py | 58.33% | 5 Missing :warning: |
aiobotocore/client.py | 92.30% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@thehesiod: Another bump that adds support for new AWS services and features.
I'm unsure how to deal with the lack of test coverage. Is this something to be concerned about?
@thehesiod: Another bump that adds support for new AWS services and features.
I'm unsure how to deal with the lack of test coverage. Is this something to be concerned about?
not reaaaly, bonus if they're added. We should probably have a task to port all the botocore tests over
will get to this today
will get to this today
I just pushed another update that extends compatibility up to yesterday's botocore release. It's all yours now ;-)
whoops didn't get to it. will do asap
going to do version w/o prefix this time, see how it goes
thanks for all the help!
I liked your strategy of supporting multiple botocore versions, probably worth adding to the docs describing how to do upgrades
actually was thinking about this last night, we can probably add a python helper where you set a base revision, and it tells you which ranges have only service json changes. Would save a lot of manual labor.
we can probably add a python helper where you set a base revision, and it tells you which ranges have only service json changes.
That's true. To reach the next level of automation, it would be nice to run a scheduled GitHub action that checks for new botocore releases and opens PRs, if these are light-weight, i.e. only contain service JSON updates. Once that is stable, these PRs could even be auto-merged after passing CI. Eventually, we could also do automated minor releases.
i like your thinking :]
Description of Change
This PR intends to improve general compatibility of
aiobotocore
within the Python ecosystem by bumping the dependency specification ofbotocore
, as well asboto3
andawscli
.It also restores feature parity with respect to recently released and improved AWS services, in particular adding support for S3 Express One Zone.
Assumptions
Upstream diff contains multiple changes that affect this codebase.
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions