aio-libs / aiobotocore

asyncio support for botocore library using aiohttp
https://aiobotocore.aio-libs.org
Apache License 2.0
1.19k stars 183 forks source link

Support up-to-date `botocore` #1069

Closed jakob-keller closed 9 months ago

jakob-keller commented 9 months ago

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by bumping the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

Upstream diff contains no significant changes that affect this codebase.

Checklist for All Submissions

Checklist when updating botocore and/or aiohttp versions

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.20%. Comparing base (bd32ed0) to head (58e0a56). Report is 75 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1069 +/- ## ========================================== - Coverage 86.25% 86.20% -0.06% ========================================== Files 60 60 Lines 5858 5858 ========================================== - Hits 5053 5050 -3 - Misses 805 808 +3 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiobotocore/pull/1069/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aio-libs/aiobotocore/pull/1069/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `86.20% <ø> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sapols commented 9 months ago

Hi @jakob-keller @thehesiod, I'm an open-source developer and sorry, but I'm finding this PR late. Is there a reason you can't support at least version 1.34.27? Or better, anything <1.35.0?

If you look at botocore's release history, they've made multiple releases in the last few days. I maintain a software environment for the Python in Heliophysics Community (PyHC), and out of hundreds of packages, aiobotocore's strict requirement of botocore<1.34.23 is the one thing breaking our build.

jakob-keller commented 9 months ago

Hi @jakob-keller @thehesiod, I'm an open-source developer and sorry, but I'm finding this PR late. Is there a reason you can't support at least version 1.34.27? Or better, anything <1.35.0?

If you look at botocore's release history, they've made multiple releases in the last few days. I maintain a software environment for the Python in Heliophysics Community (PyHC), and out of hundreds of packages, aiobotocore's strict requirement of botocore<1.34.23 is the one thing breaking our build.

Due to the way aiobotocore is implemented and botocore releases are versioned, there is no safe way to declare compatibility with future releases of botocore. I have turned your request into #1078 and will provide a PR shortly.

sapols commented 9 months ago

@jakob-keller understood. Thanks for the quick response and new issue! That's all I could ask for.