Closed jakob-keller closed 7 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
110b0a2
) 86.13% compared to head (9097884
) 86.25%.
Files | Patch % | Lines |
---|---|---|
aiobotocore/utils.py | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@thehesiod: I'm looking forward to your review.
mind just bumping the release date then I'll merge and deploy. Thanks! very nice implementation
Description of Change
A race condition in the S3 Express identity cache was introduced in 110b0a2a. This change modifies the cache to hold
asyncio.Task
instances instead of actual credentials to mitigate the issue without introducing locking.Assumptions
Replace this text with any assumptions made (if any)
Checklist for All Submissions
asyncio.Task
instances that wrap the underlyingget_credentials
coroutine.Checklist when updating botocore and/or aiohttp versions