aio-libs / aiobotocore

asyncio support for botocore library using aiohttp
https://aiobotocore.rtfd.io
Apache License 2.0
1.14k stars 179 forks source link

Address breaking change introduced in `aiohttp==3.9.2` #1081

Closed jakob-keller closed 3 months ago

jakob-keller commented 6 months ago

Description of Change

aiohttp==3.9.2 introduces a change in handling SSL/TLS-related arguments that breaks our code. This PR applies current aiohttp best-practices to SSL/TLS-related arguments.

Assumptions

Checklist for All Submissions

Checklist when updating botocore and/or aiohttp versions

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.28%. Comparing base (2d6520b) to head (05c9321).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1081 +/- ## ========================================== - Coverage 86.33% 86.28% -0.06% ========================================== Files 62 62 Lines 5913 5913 ========================================== - Hits 5105 5102 -3 - Misses 808 811 +3 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiobotocore/pull/1081/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aio-libs/aiobotocore/pull/1081/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `86.28% <100.00%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dacevedo12 commented 6 months ago

Seems like they addressed this in 3.9.3 https://github.com/aio-libs/aiohttp/pull/8098

jakob-keller commented 6 months ago

Seems like they addressed this in 3.9.3 aio-libs/aiohttp#8098

Indeed, still we should cease using the deprecated verify_ssl argument to prevent this issue from popping up again in the future.

jakkdl commented 6 months ago

Seems like they addressed this in 3.9.3 aio-libs/aiohttp#8098

Indeed, still we should cease using the deprecated verify_ssl argument to prevent this issue from popping up again in the future.

perhaps of note is that #749 (which I've been slowly chugging away on) wants to replace aiohttp with httpx, so there might not be a very long future for aiohttp.

jakob-keller commented 6 months ago

@thehesiod: This PR builds on #1077. Maybe we should first finish that PR?

jakob-keller commented 3 months ago

CI doesn't allow for two releases dated the same in CHANGES.txt :-(

thehesiod commented 3 months ago

will fix test here, one sec