Closed jakob-keller closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.28%. Comparing base (
2d6520b
) to head (05c9321
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Seems like they addressed this in 3.9.3 https://github.com/aio-libs/aiohttp/pull/8098
Seems like they addressed this in 3.9.3 aio-libs/aiohttp#8098
Indeed, still we should cease using the deprecated verify_ssl
argument to prevent this issue from popping up again in the future.
Seems like they addressed this in 3.9.3 aio-libs/aiohttp#8098
Indeed, still we should cease using the deprecated
verify_ssl
argument to prevent this issue from popping up again in the future.
perhaps of note is that #749 (which I've been slowly chugging away on) wants to replace aiohttp with httpx, so there might not be a very long future for aiohttp.
@thehesiod: This PR builds on #1077. Maybe we should first finish that PR?
CI doesn't allow for two releases dated the same in CHANGES.txt :-(
will fix test here, one sec
Description of Change
aiohttp==3.9.2
introduces a change in handling SSL/TLS-related arguments that breaks our code. This PR applies currentaiohttp
best-practices to SSL/TLS-related arguments.Assumptions
aiohttp
was bumped to prevent regressions with our updated code andaiohttp<3.9.2
.Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions