Open FeeeeK opened 5 months ago
Hello and thanks for reporting!
I believe you are correct: StreamingBody
is indeed not iterable. The false positive isinstance
check appears to be due to having wrapt.ObjectProxy
as a parent class.
There might be several ways to deal with this issue:
wrapt.ObjectProxy
play nicely with isinstance checks by addressing the issue upstreamStreamingBody
to ensure isinstance check returns expected result (if possible)wrapt.ObjectProxy
as a parent class@thehesiod: Any thoughts?
Looks like this issue is already 8 years old: https://github.com/GrahamDumpleton/wrapt/issues/93 so it seems to me that option 3 would most likely be the solution
Looks like this issue is already 8 years old: GrahamDumpleton/wrapt#93 so it seems to me that option 3 would most likely be the solution
That's what I feared
nice detective work. we can drop the proxy, just means we'll have to be more careful when upgrading
On Mon, Mar 11, 2024, 7:07 AM Jakob Keller @.***> wrote:
Looks like this issue is already 8 years old: GrahamDumpleton/wrapt#93 https://github.com/GrahamDumpleton/wrapt/issues/93 so it seems to me that option 3 would most likely be the solution
That's what I feared
— Reply to this email directly, view it on GitHub https://github.com/aio-libs/aiobotocore/issues/1098#issuecomment-1988529691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6Q77PQJ24X5OMKDFBQCH3YXW3DRAVCNFSM6AAAAABEQI7O6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBYGUZDSNRZGE . You are receiving this because you were mentioned.Message ID: @.***>
I'll try to get a fix for this out soon, was hoping someone would come with a pr before me :)
Describe the bug
StreamingBody
returnsTrue
forisinstance
Iterable
check when it shouldn't, this can lead to some problems, for example, wrong content encoding in httpx (link) and inability to useStreamingBody
ascontent
inhttpx.AsyncClient
Checklist
pip check
passes without errorspip freeze
resultspip freeze results
Environment:
Additional context Add any other context about the problem here.