aio-libs / aiobotocore

asyncio support for botocore library using aiohttp
https://aiobotocore.rtfd.io
Apache License 2.0
1.14k stars 179 forks source link

small fixes to coverage, type hints, documentation, and QoL for Makefile #1101

Closed jakkdl closed 4 months ago

jakkdl commented 5 months ago

Description of Change

Minor issues I noticed while writing #1085. Split out from it to make the diff smaller.

Nothing in the checklist should be relevant for this, all the changes should be uncontroversial improvements.

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

Checklist when updating botocore and/or aiohttp versions

jakkdl commented 5 months ago

codecov fail is a rate limit error:

debug - 2024-03-20 11:02:14,016 -- Commit creating result --- {"result": "RequestResult(error=RequestError(code='HTTP Error 429', params={}, description='{\"detail\":\"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 827 seconds.\"}'), warnings=[], status_code=429, text='{\"detail\":\"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 827 seconds.\"}')"} error - 2024-03-20 11:02:14,016 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 827 seconds."}

jakkdl commented 5 months ago

same rate limit error as in https://github.com/aio-libs/aiobotocore/pull/1101#issuecomment-2009324529

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.30%. Comparing base (e8a3b8e) to head (d70635f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1101 +/- ## ======================================= Coverage 86.29% 86.30% ======================================= Files 62 62 Lines 5889 5891 +2 ======================================= + Hits 5082 5084 +2 Misses 807 807 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiobotocore/pull/1101/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aio-libs/aiobotocore/pull/1101/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `86.30% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.