Closed ayushjain01 closed 2 months ago
omg 317M/mo? holy cow
something tells me there be bugs, or someone hammering the downloads lol
I guess it's correct, at least matches
SELECT COUNT(*) AS num_downloads
FROM `bigquery-public-data.pypi.file_downloads`
WHERE file.project = 'aiobotocore'
-- Only query the last 30 days of history
AND DATE(timestamp)
BETWEEN DATE_SUB(CURRENT_DATE(), INTERVAL 30 DAY)
AND CURRENT_DATE()
error is unrelated, going to force merge
ty!
top 10 btw:
1 | boto3 | 1437346653 |
2 | botocore | 653582073 |
3 | urllib3 | 546673014 |
4 | requests | 489360227 |
5 | wheel | 482689138 |
6 | certifi | 433404786 |
7 | idna | 428778797 |
8 | typing-extensions | 426101807 |
9 | charset-normalizer | 421344603 |
10 | pip | 390331460
Thanks for merging the PR. Glad you liked it.
something tells me there be bugs, or someone hammering the downloads lol
You might be onto something: rank 11 on that list is currently pypular which itself claims:
The purpose of this tool is to download python packages from PYPI multiple times, to inflate the download counter.
That severly undermines credibility of the download counts, IMO. Is that even allowed as per PyPI terms of use?
ya something seems fishy. why would someone want to do that for these modules
Note there is discussion of the need for such a badge on numpy/numpy#26500.
Note there is discussion of the need for such a badge on numpy/numpy#26500.
I agree. Besides driving traffic to that third party site, it could also be considered a security issue, since it allows for uncontrolled loading of external content. I am in favour of removing the badge.
@jakob-keller hmm pypi.org also links to https://libraries.io/ which is also a commercial enterprise. I don't see the download stats on pypi.org, where is that available?
@jakob-keller hmm pypi.org also links to https://libraries.io/ which is also a commercial enterprise. I don't see the download stats on pypi.org, where is that available?
Stats are not available directly from pypi.org: https://pypi.org/help/#statistics
My issue does not lie with libraries.io, but with piptrends.com, which appears to be less established and provided by an individual. The site features sub-par advertising, when I look at it.
@jakob-keller I've gone ahead and re-done the badges based on that numpy thread, lemme know what you think
@jakob-keller I've gone ahead and re-done the badges based on that numpy thread, lemme know what you think
LGTM!
Note there is discussion of the need for such a badge on numpy/numpy#26500.
I agree. Besides driving traffic to that third party site, it could also be considered a security issue, since it allows for uncontrolled loading of external content. I am in favour of removing the badge.
@jakob-keller - I believe the readme already has badges from external sites. I don't see any security issue associated with just one badge - that clearly just displays a more accurate download count.
@jakob-keller hmm pypi.org also links to https://libraries.io/ which is also a commercial enterprise. I don't see the download stats on pypi.org, where is that available?
Stats are not available directly from pypi.org: https://pypi.org/help/#statistics
My issue does not lie with libraries.io, but with piptrends.com, which appears to be less established and provided by an individual. ~The site features sub-par advertising, when I look at it.~
We're a small team trying to contribute something to the community, We don't have any advertising and aren't planning to add anything in the future as well. It's less established since we're just getting started. Even librairies.io was less established in the beginning right?
There were concerns to the external link to piptrends.com, which is alright, you can remove the link if you don't want visitors to go check the package page on piptrends, which only has more information about the package and content to get started with - again contributed by people.
@ayushjain01: Thank you for taking the time to explain your position.
In any case, good look with your project.
If y'all haven't already, I think you should revert the merge.
A colleague of this person tried to open this exact PR against a project I'm the maintainer for as well (https://github.com/ixmatus/inflector/pull/16). This is a promotional campaign and they (or colleagues) appear to be doing it on reddit too, I think this is suspicious activity. They are creating an external dependency on a web property that (as far as I can tell) is not officially blessed by pypi.
Users can get package statistics from libraries.io
which is linked to directly by pypi itself.
@ixmatus, they already did the revert. Thanks for noticing that 🙏🏻
Description of Change
Added a monthly downloads badge by pip Trends to the README. View more at - https://piptrends.com/widgets/pyyaml
Assumptions
None
Checklist for All Submissions (none apply)
Checklist when updating botocore and/or aiohttp versions