aio-libs / aiobotocore

asyncio support for botocore library using aiohttp
https://aiobotocore.rtfd.io
Apache License 2.0
1.14k stars 179 forks source link

Update Botocore to 1.34.131 #1122

Closed lou-k closed 1 month ago

lou-k commented 1 month ago

Description of Change

Updates botocore to 1.34.131

There is no added functionality in 1.34.131:

git diff --name-status 1.34.106...1.34.131 botocore/ | grep py$
M   botocore/__init__.py
M   botocore/retries/standard.py
M   botocore/utils.py

but I'd like to use the latest boto3 in my project, and the existing <1.34.107 is causing a dependency issue.

Assumptions

I got some errors on make cov before I made any changes. I'm assuming that is an issue with my local environment and CICD will pass here...

Checklist for All Submissions

Checklist when updating botocore and/or aiohttp versions

Tests Run Locally

pytest -sv tests/test_patches.py 
 ======================================== test session starts  ========================================
platform darwin -- Python 3.12.3, pytest-8.1.1, pluggy-1.5.0 -- /Users/lou/.local/share/virtualenvs/aiobotocore-UGsiy0fU/bin/python
cachedir: /tmp/pytest_aiobotocore_cache
rootdir: /Users/lou/repos/aiobotocore
configfile: pyproject.toml
plugins: cov-5.0.0, asyncio-0.21.2, xdist-3.5.0
asyncio: mode=Mode.AUTO
collected 2 items                                                                                                                                                                                                                                            

tests/test_patches.py::test_protocol_parsers PASSED
tests/test_patches.py::test_patches Botocore version: 1.34.131
PASSED

 ======================================== 2 passed in 0.20s ========================================

Thanks for the easy-to-follow guide on updating this!

lou-k commented 1 month ago

thanks for the eyes, @jakob-keller !

jakob-keller commented 1 month ago

closes #1123

thehesiod commented 1 month ago

oh we hit this error at work, need to upgrade docker/requests IIRC

thehesiod commented 1 month ago

ughh, ci tool

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.33%. Comparing base (ec33cb7) to head (8eaaa40). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1122 +/- ## ========================================== + Coverage 86.28% 86.33% +0.05% ========================================== Files 62 62 Lines 5913 5913 ========================================== + Hits 5102 5105 +3 + Misses 811 808 -3 ``` | [Flag](https://app.codecov.io/gh/aio-libs/aiobotocore/pull/1122/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aio-libs/aiobotocore/pull/1122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs) | `86.33% <100.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aio-libs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thehesiod commented 1 month ago

sweet!