search

aio-libs / aiobotocore

asyncio support for botocore library using aiohttp
https://aiobotocore.aio-libs.org
Apache License 2.0
1.2k stars 183 forks source link

[tracking] yarl 1.9.10+ breaks opensearch sigv4 calls #1200

Closed thehesiod closed 1 month ago

thehesiod commented 1 month ago

I'm temporarily putting this as a warning for others as we just discovered this. It caused some prod downtime (can't easily mock SigV4 unless you haven an opensearch moto client with docker backend) and was fairly involved to track down.

We still need to do a deep dive however on a recent update to aiobotocore, which (unrelatedly) ended up pulling a newer yarl release, many of our opensearch calls were failing with 400 and no information as to the actual issue. We tracked it down to yarl 1.9.10 however after initial investigation have not figured out how it's breaking the calls.

We'll do a deep dive soon and log issue on yarl and report back here and then close this issue. If it's bad enough we can add a version exclusion to the requirements to prevent the same issue for others.

thehesiod commented 1 month ago

tracked it down: https://github.com/aio-libs/yarl/issues/1116

thehesiod commented 1 month ago

given this is reliant on one using URL.join I'm going to close as it's fairly specific to one's use case