search

aio-libs / aiodns

Simple DNS resolver for asyncio
https://pypi.python.org/pypi/aiodns
MIT License
532 stars 69 forks source link

Convert Type Annotations to Py3 syntax #76

Closed cooperlees closed 4 years ago

cooperlees commented 4 years ago

Since this project is now >= Python 3.5 we can move all type annotations to Python 3 syntax except variable annotations (they will need to stay as comments until the project is >= 3.6).

Happy to do the PR one day and also happy if someone else beats me. I did PR #75 to add CI type checking, ensuring master is passing before we convert.

Not sure if there are tools to do this for us, but manual wouldn’t take to long.

mimi89999 commented 4 years ago

I guess that it would also be good to annotate pycares.

cooperlees commented 4 years ago

I guess that it would also be good to annotate pycares.

For sure. But I feel that should be an issue over at https://github.com/saghul/pycares :)

cooperlees commented 4 years ago

Did it: https://github.com/saghul/pycares/issues/112

mimi89999 commented 4 years ago

I opened a PR :wink: